Bug 139129

Created attachment 242310 [details] Patch

Comment on attachment 242310 [details] Patch Rejecting attachment 242310 [details] from commit-queue. zimbabao@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Comment on attachment 242310 [details] Patch Attachment 242310 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6331413246771200 New failing tests: fast/dom/collection-null-like-arguments.html fast/dom/htmlallcollection-call-with-index-caching-bug.html

Created attachment 242314 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 242310 [details] Patch Attachment 242310 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5108600087248896 New failing tests: fast/dom/collection-null-like-arguments.html fast/dom/htmlallcollection-call-with-index-caching-bug.html

Created attachment 242315 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 242310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242310&action=review > Source/WebCore/ChangeLog:8 > + No new tests This definitely needs tests.

Created attachment 242399 [details] Patch

Comment on attachment 242399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242399&action=review > Source/JavaScriptCore/runtime/CallData.h:45 > + CallTypeCallbleNonFunctionHost, "Callble" is not a word

Created attachment 242419 [details] Patch

Comment on attachment 242419 [details] Patch It's almost certainly wrong to do this just for document.all. What about all the other callable APIs in the DOM? Also, why do we think that undefined is the right value for typeof? What's the source on that?

@ggaren: Doing it for document.write because that what is mentioned in spec https://html.spec.whatwg.org/#dom-document-all "The user agent must act such that the typeof operator in JavaScript returns the string undefined when applied to the object returned for all." Are there more such APIs?. Also at present (type=typeof document.all, type === 'function')", "(typeof document.all === 'function') return false. Equivalent code pieces giving out different results, which is wrong. and currently typeof document.all returnrs 'undefined'.

Comment on attachment 242419 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.