Bug 138285

Summary: Support modern range loops over CSSValueList
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-11-01 16:00:06 PDT
We should support modern range loops over CSSValueList and kill the custom CSSValueListInspector / CSSValueListIterator classes to modernize the code a bit.
Attachments
Patch (50.56 KB, patch)
2014-11-01 18:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.58 KB, patch)
2014-11-01 18:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.57 KB, patch)
2014-11-03 09:08 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (51.33 KB, patch)
2014-11-03 12:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-01 18:10:02 PDT
Created attachment 240798 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-01 18:11:24 PDT
Attachment 240798 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2014-11-01 18:35:08 PDT
Created attachment 240800 [details] Patch
WebKit Commit Bot
Comment 4 2014-11-01 18:37:36 PDT
Attachment 240800 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2014-11-03 09:08:09 PST
Created attachment 240856 [details] Patch
WebKit Commit Bot
Comment 6 2014-11-03 09:09:47 PST
Attachment 240856 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 7 2014-11-03 12:03:03 PST
Comment on attachment 240856 [details] Patch r=me
Chris Dumez
Comment 8 2014-11-03 12:25:44 PST
Created attachment 240867 [details] Patch
WebKit Commit Bot
Comment 9 2014-11-03 12:27:50 PST
Attachment 240867 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2014-11-03 12:48:18 PST
Comment on attachment 240867 [details] Patch Clearing flags on attachment: 240867 Committed r175487: <http://trac.webkit.org/changeset/175487>
WebKit Commit Bot
Comment 11 2014-11-03 12:48:23 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 12 2014-11-03 14:20:22 PST
Comment on attachment 240867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240867&action=review > Source/WebCore/css/StyleResolver.cpp:2037 > + ASSERT(it != values.end()); arf. This should be it == values.end(), my bad. will fix now.
Chris Dumez
Comment 13 2014-11-03 14:22:40 PST
(In reply to comment #12) > Comment on attachment 240867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240867&action=review > > > Source/WebCore/css/StyleResolver.cpp:2037 > > + ASSERT(it != values.end()); > > arf. This should be it == values.end(), my bad. will fix now. Landed assertion fix in <http://trac.webkit.org/changeset/175490>.
Note You need to log in before you can comment on or make changes to this bug.