Bug 137595

Summary: Use is<>() / downcast<>() for GraphicsLayer subclasses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, darin, kling, kondapallykalyan, rniwa, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Patch
none
Patch none

Chris Dumez
Reported 2014-10-09 21:03:46 PDT
Use is<>() / downcast<>() for GraphicsLayer subclasses
Attachments
Patch (22.61 KB, patch)
2014-10-09 21:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (645.00 KB, application/zip)
2014-10-10 00:42 PDT, Build Bot 		no flags
Details
Patch (22.60 KB, patch)
2014-10-10 08:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.81 KB, patch)
2014-10-10 09:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-09 21:15:54 PDT
Created attachment 239599 [details] Patch
Build Bot
Comment 2 2014-10-10 00:42:12 PDT
Comment on attachment 239599 [details] Patch Attachment 239599 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5451520141164544 New failing tests: mathml/opentype/munderover-window-resize.html
Build Bot
Comment 3 2014-10-10 00:42:17 PDT
Created attachment 239606 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Chris Dumez
Comment 4 2014-10-10 08:33:13 PDT
Created attachment 239627 [details] Patch
Darin Adler
Comment 5 2014-10-10 09:43:01 PDT
Comment on attachment 239627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239627&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3200 > size_t numChildren = childLayers.size(); > for (size_t i = 0; i < numChildren; ++i) { Should use a modern for loop. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3203 > clonalSublayers.append(childLayer); Should be childLayer.release().
Chris Dumez
Comment 6 2014-10-10 09:49:35 PDT
Created attachment 239632 [details] Patch
WebKit Commit Bot
Comment 7 2014-10-10 10:51:04 PDT
Comment on attachment 239632 [details] Patch Clearing flags on attachment: 239632 Committed r174602: <http://trac.webkit.org/changeset/174602>
WebKit Commit Bot
Comment 8 2014-10-10 10:51:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.