Bug 117414

Summary: Autoclose braces and parentheses at the end of style sheet
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kling, macpherson, menard, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117401    
Bug Blocks: 116071    
Attachments:
Description Flags
Patch none

Sergio Villar Senin
Reported 2013-06-10 10:23:48 PDT
We should consider merging: https://src.chromium.org/viewvc/blink?view=rev&revision=150202 Autoclosing braces and parentheses at TOKEN_EOF in CSS grammar. It's consistent with the spec http://www.w3.org/TR/CSS21/syndata.html#parsing-errors which mentions that: "User agents must close all open constructs (for example: blocks, parentheses, brackets, rules, strings, and comments) at the end of the style sheet"
Attachments
Patch (9.03 KB, patch)
2013-06-10 10:36 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-06-10 10:36:51 PDT
Created attachment 204174 [details] Patch
Andreas Kling
Comment 2 2013-06-10 14:41:49 PDT
Comment on attachment 204174 [details] Patch Good pick. r=me
Sergio Villar Senin
Comment 3 2013-06-11 00:10:13 PDT
Comment on attachment 204174 [details] Patch Clearing flags on attachment: 204174 Committed r151424: <http://trac.webkit.org/changeset/151424>
Sergio Villar Senin
Comment 4 2013-06-11 00:10:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.