Bug 116072
| Summary: | Fix CSS parsing recovery in function | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | CSS | Assignee: | Glenn Adams <glenn> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, dino, glenn, kling, koivisto, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
We should probably merge
https://chromium.googlesource.com/chromium/blink/+/667d02b44baeec91bc357c14e92fcbe2e9378212
prop: expt(});
color: red;
}
and
prop: expt(10px });
color: red;
}
are parsed differently.
This change fixes that. Not completely though: difference occures if wrong part contains parentheses.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I took the test case from Blink patch-set and changed it into JSFiddle:
Link - https://jsfiddle.net/cbu9aje8/show
It shows "PASS" (in green) for all browsers, I think it was fixed along the way and this can be considered as "RESOLVED CONFIGURATION CHANGED". Thanks!
Ryosuke Niwa
Yeah, I'm sure adopting blink's CSS parser fixed this.