Bug 114558

Summary: Isolate Early Warning System definitions into a JSON
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: alancutter, benjamin, commit-queue, dpranke, gyuyoung.kim, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159990
Bug Depends on: 114669, 114737    
Bug Blocks: 114564    
Attachments:
Description Flags
Adds ews.json benjamin: review+

Ryosuke Niwa
Reported 2013-04-13 03:13:29 PDT
Isolate Early Warning System defintions into a JSON
Attachments
Adds ews.json (9.36 KB, patch)
2013-04-13 03:16 PDT, Ryosuke Niwa 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-13 03:16:45 PDT
Created attachment 197930 [details] Adds ews.json
Benjamin Poulain
Comment 2 2013-04-13 21:56:05 PDT
Comment on attachment 197930 [details] Adds ews.json View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review > Tools/ChangeLog:3 > + Isolate Early Warning System defintions into a JSON Typo: defintions > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:155 > + 'run_tests': config.get('runTests', False), cls.run_tests?
Alan Cutter
Comment 3 2013-04-14 07:02:20 PDT
I'm glad to see this change to the EWS, any plans for the QueueStatusServer to use the same data?
Ryosuke Niwa
Comment 4 2013-04-16 00:42:32 PDT
Committed r148498: <http://trac.webkit.org/changeset/148498>
WebKit Commit Bot
Comment 5 2013-04-16 01:21:17 PDT
Re-opened since this is blocked by bug 114669
Ryosuke Niwa
Comment 6 2013-04-16 18:40:15 PDT
Committed r148588: <http://trac.webkit.org/changeset/148588>
Csaba Osztrogonác
Comment 7 2013-04-17 06:16:07 PDT
Comment on attachment 197930 [details] Adds ews.json View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:152 > + 'name': config['port'] + '-ews', This change killed the Qt WK2 EWS, because the port is qt, but its name should be qt-wk2-ews.
Csaba Osztrogonác
Comment 8 2013-04-17 06:41:49 PDT
Fix is coming soon in https://bugs.webkit.org/show_bug.cgi?id=114737
Note You need to log in before you can comment on or make changes to this bug.