Bug 112509

Summary: Stack overflow occurs in Windows build on startup
Product: WebKit Reporter: Peter Nelson <peter>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: peavo, peter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch ap: review+

Peter Nelson
Reported 2013-03-16 18:21:22 PDT
Currently in the Windows build, on startup, WebView::setSelectTrailingWhitespaceEnabled and WebView::setSmartInsertDeleteEnabled recursively call each other until a stack overflow occurs. I believe this is a regression caused by changeset 145849 (http://trac.webkit.org/changeset/145849)
Attachments
Patch (1.90 KB, patch)
2013-03-16 18:34 PDT, Peter Nelson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Nelson
Comment 1 2013-03-16 18:34:19 PDT
Created attachment 193451 [details] Patch
Peter Nelson
Comment 2 2013-03-16 18:35:42 PDT
Just made the conditional logic in these methods consistent with the corresponding methods in WebKit/mac/WebView/WebView.mm.
Alexey Proskuryakov
Comment 3 2013-03-18 10:59:59 PDT
*** Bug 112572 has been marked as a duplicate of this bug. ***
Peter Nelson
Comment 4 2013-03-18 12:56:27 PDT
This is now fixed: http://trac.webkit.org/changeset/146097
Note You need to log in before you can comment on or make changes to this bug.