Bug 106242

Summary: [EFL] Enable scaled cursors
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99493    
Bug Blocks: 106240    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch
none
Patch
gyuyoung.kim: review+
Patch for landing none

Chris Dumez
Reported 2013-01-07 11:56:58 PST
Cursor image scaling should be enabled via ENABLE_MOUSE_CURSOR_SCALE flag. Some work is also needed in CursorEfl.cpp and for the WK2 Cursor serialization.
Attachments
Patch (8.96 KB, patch)
2013-01-07 12:08 PST, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (9.53 KB, patch)
2013-01-07 13:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2013-01-09 09:00 PST, Chris Dumez 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
Patch for landing (7.26 KB, patch)
2013-04-30 05:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-07 12:08:24 PST
Created attachment 181543 [details] Patch
Build Bot
Comment 2 2013-01-07 13:04:32 PST
Comment on attachment 181543 [details] Patch Attachment 181543 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15739860
Chris Dumez
Comment 3 2013-01-07 13:21:48 PST
Created attachment 181548 [details] Patch Export additional symbol to attempt to fix mac build.
Chris Dumez
Comment 4 2013-01-09 07:31:55 PST
I am splitting the WK2-part to Bug 106455 to get review from a WK2 Owner.
Chris Dumez
Comment 5 2013-01-09 09:00:00 PST
Created attachment 181930 [details] Patch I simplified the patch. We don't need the change to WK2 IPC after all.
Chris Dumez
Comment 6 2013-01-19 10:55:11 PST
Could someone please take a look?
Gyuyoung Kim
Comment 7 2013-04-30 04:02:45 PDT
Comment on attachment 181930 [details] Patch LGTM, BTW, can this feature run on EFL WK1 as well ?
Chris Dumez
Comment 8 2013-04-30 05:14:15 PDT
Created attachment 200100 [details] Patch for landing
Chris Dumez
Comment 9 2013-04-30 05:34:19 PDT
(In reply to comment #7) > (From update of attachment 181930 [details]) > LGTM, BTW, can this feature run on EFL WK1 as well ? The parsing part and therefore the test yes.
WebKit Commit Bot
Comment 10 2013-04-30 06:16:21 PDT
Comment on attachment 200100 [details] Patch for landing Clearing flags on attachment: 200100 Committed r149362: <http://trac.webkit.org/changeset/149362>
WebKit Commit Bot
Comment 11 2013-04-30 06:16:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.