Bug 101606

Summary:

DOMException name is incorrect

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

DOM

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, darin, haraken, mjs, ojan

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://dom.spec.whatwg.org/#domexception

Bug Depends on:

102087, 102089, 102092, 102096, 102128, 102132, 102134, 102137, 102139, 102141, 102241, 102279, 102281, 102395, 102400, 102416, 102418, 102437, 102503, 102508, 102511, 102512, 102513, 102519, 102521

Bug Blocks:

102505

Attachments:

Description	Flags
Patch	arv: review-

Erik Arvidsson

Reported 2012-11-08 07:51:13 PST

try { document.appendChild(document); } catch (ex) { console.log(ex.name) } This logs "HIERARCHY_REQUEST_ERR" when it should log "HierarchyRequestError"

Attachments
Patch (804.16 KB, patch) 2012-11-12 14:35 PST, Erik Arvidsson	arv: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2012-11-12 14:35:04 PST

Created attachment 173731 [details] Patch

Erik Arvidsson

Comment 2 2012-11-12 14:36:35 PST

Sorry about the size of this patch. Maybe these are better done as a two step process where a rebaseline is done afterwards?

Adam Barth

Comment 3 2012-11-12 15:07:18 PST

Does this match Firefox?

Erik Arvidsson

Comment 4 2012-11-12 15:17:19 PST

(In reply to comment #3) > Does this match Firefox? Yes, this matches the spec and Firefox (I added that to the ChangeLog but not to this bug).

Kentaro Hara

Comment 5 2012-11-12 15:56:09 PST

I'm for this change.

Maciej Stachowiak

Comment 6 2012-11-12 20:50:09 PST

Seems like a sensible change in general; is there any way to do this more incrementally? I have bad memories of patches this size. When a huge patch (even a seemingly mechanical one) causes a regression, it can be very hard to diagnose. Perhaps this could be done one exception at a time, or a few DOM classes at a time, instead of all at once.

Erik Arvidsson

Comment 7 2012-11-13 07:20:02 PST

(In reply to comment #6) > Seems like a sensible change in general; is there any way to do this more incrementally? I have bad memories of patches this size. When a huge patch (even a seemingly mechanical one) causes a regression, it can be very hard to diagnose. > > Perhaps this could be done one exception at a time, or a few DOM classes at a time, instead of all at once. Makes sense. I'll split the changes into smaller patches.

Erik Arvidsson

Comment 8 2012-11-13 09:01:03 PST

Comment on attachment 173731 [details] Patch I'm doing all of these one patch at a time.

Erik Arvidsson

Comment 9 2012-11-19 10:40:31 PST

All dependent bugs done.

Note You need to log in before you can comment on or make changes to this bug.